Design comparison
Solution retrospective
What did you find difficult about that project?
What elements did you use the most?
What advice can you give me about my code?
What is your feedback for my work?
Community feedback
- @danielmrz-devPosted 11 months ago
Hello @Jwalt95!
Your solution looks great!
I have a couple of suggestions for improvement:
- For semantic reasons, and since that is the main title of the screen, you can replace the
<h4>
with<h1>
.
The
<h1>
to<h6>
tags are used to define HTML headings.<h1>
defines the most important heading.<h6>
defines the least important heading. Only use one<h1>
per page - this should represent the main heading/subject for the whole page. Also, do not skip heading levels - start with<h1>
, then use<h2>
, and so on.- Also, still about semantic HTML, you can replace your
div.mother-content
withmain.mother-content
.
All these changes may have little or no visual impact but they make your HTML code more semantic and improve SEO optimization as well as the accessibility of your project.
I hope it helps!
Other than that, great job!
0@Jwalt95Posted 11 months agoThank you very much for the feedback. I will make sure I apply the advices in my next project.@danielmrz-dev
0 - For semantic reasons, and since that is the main title of the screen, you can replace the
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord