Responsive base-apparel-coming-soon-page

Community feedback

• 

  バレンタイン 😈•64,170

  @VCaramesPosted over 1 year ago

  Hey there! 👋 Here are some suggestions to help improve your code:

  • This definitely needs to take up the entire screen as the original designed is.

  • You validation needs work as it will accept the following email address "email@[email protected]" as valid.

  • The logo’s alt tag description needs to be improved upon ⚠️; it should state the company’s name.

  • This "arrow-right" should be built using a button element.

  • Your email input ⚠️ needs to have a visibly hidden label attached to it for improved accessibility.

  MDN Label Element

  • The EventListener ⚠️ in your JS should be a submit not a click, since the user is submitting their email.

  More Info:📚

  Click vs. Submit EventListeners

  Happy Coding! 👾

  Marked as helpful

  1
• 

  P

  visualdennis•8,375

  @visualdennissPosted over 1 year ago

  Good job completing the challenge successfully! Your solution overall looks great.

  I'd have a suggestion regarding user experience. I think it would be better if the send button didn't move to right when hovering, as it feels like it is abruptly running away from the curson. Instead you can use subtle background color change with a smooth animation with transition: background .4s ease;

  Hope you find this feedback helpful!

  Marked as helpful

  0