Design comparison
SolutionDesign
Solution retrospective
it was nice challenge , it took little time with me as a beginner with JS but it's done :)
Community feedback
- @tesla-ambassadorPosted over 2 years ago
Hey Vampmora. Congrats on completing this really good challenge! It's really responsive and looks sharp I also like that you change the cases of the first letter in the email and the first letter after the '@' symbol. Here's a few pointers:
- Consider adding a
setTimeOut();
function on submission of the email to reload the page a few seconds after an email has successfully been submitted so that it can simulate a real-life email submission. You can use thewindow.location.reload();
function to achieve this. (The reloading of the page) - In order to resolve some of your accessibility issues, you might wanna use landmarks in your html code, these help browsers easily navigate your code. So you might consider wrapping your divs in landmarks like
<main>
or<header>
or<footer>
you need to do this according to how your page is structured. Incase you want to know more about landmarks, follow this link.
Happy coding and keep up the good work!
Marked as helpful0@vampmoraPosted over 2 years ago@tesla-ambassador thank you so much for for your notes , will do my best to make my code better :)
0 - Consider adding a
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord