Design comparison
Community feedback
- @shubhsaurPosted over 2 years ago
Hey Lorenzo,
Appreciate your inputs, surely will try above points. Thanks!👍🏻
1 - @LfrancosPosted over 2 years ago
Hello Shubham!
This is looking really good. The solutions that you found form some things are really inspiring.
There are a couple of things that I would try to do.
-
I would try to have 2 messages, one for when the email is not valid, and one when the field is empty. I think that would give clearer information to the user.
-
if I add an email I should be able to submit the form. to fix that you could take the "e.preventDefault()" and put it with in the if. That way you'll make sure that it is functioning with the "if" statement.
-
the button of the submit form when resizing the page should stay in the right position. First I would change the width of the email-input to "100%". Then I would change the "right: 1.2rem" to "right: 0" of the "arrow-btn"
Other than that I think this is looking really good! Congratulations and keep going with the AWESOME work : )
1 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord