Responsive Bar code scanner

Community feedback

• 

  Shravan Kumar•50

  @shravankumartalabhaktulaPosted over 2 years ago

  Hi Ankit Mishra,

  • It seems like you have not followed the design guidelines from the images. Your output is not looking same as the expected one.
  • The code is not responsive as well.

  Please re-try the challenge again by following mobile-first design approach and make the output as much close as possible to the expected output. Thanks.

  Marked as helpful

  0

  ---

  

  ankit mishra•40

  @ankit951githubPosted over 2 years ago

  @shravankumartalabhaktula Thanks for your feed back.

  0
• 

  Travolgi 🍕•31,400

  @denieldenPosted over 2 years ago

  Hi Ankit, great work on this challenge! 😉

  Here are a few tips for improve your code:

  • separe the div attribution from div wraper
  • add main tag and wrap the card for improve the Accessibility
  • to make it look as close to the design as possible add width: 20rem to wraper class
  • centering a div with absolute positioning is now deprecated, it uses modern css like flexbox or grid
  • use flexbox to the body to center the card. Read here -> best flex guide
  • after, add min-height: 100vh to body because Flexbox aligns child items to the size of the parent container
  • instead of using px or % use relative units of measurement like rem -> read here

  Overall you did well 😁 Hope this help!

  0