Responsive article preview using flexbox

Community feedback

• 

  Rastislav Hepner•180

  @raswondersPosted 3 months ago

  Hi, congratulation on finishing this challenge!

  I like your take on shared component and using of inline svgs. They seem to render asap. In my solution I loaded them via <img> but they seem to have some delay to them.

  If i can give you a tip how to make experience little better I'd make ArticleCard more responsive. ArticleCard has currently fixed size which make it quite rigid and hard to reuse. One place where rigidity shows up is distorted Image, which is sized up relative to its parent while ignoring its intrinsic aspect ratio.

  I think solution in general could be to leave elements grow with their content and only cap the extremes either by putting hard stop to it with max-* or by shifting layout.

  I'd also suggest cleaning up the code a little, removing unused code, fixing spelling mistakes like setiSClicked, running code through formatter etc. This would put a little bit of shine to it and showed that you care.

  Hopefully you find my rumblings at least somewhat useful.

  Good luck with future challenges!

  Marked as helpful

  1

  ---

  

  Mesroua Djamel•430

  @MesrouaDjamelPosted 3 months ago

  @raswonders thank you for your feedback it s very useful

  0