Design comparison
Solution retrospective
HAWHDFWAFIHEOPHIOHG REGGH G GHORHRE SOGI HREHRESHIORERELS! HAHAHAHAHAHAHAHAHAHAHAHHAHAAHAHAHHAAH! HAHAHAHAHHHAHAAHAHAHAHAHHAHAHAHAHA! IT'S OVER!!!!!!!!! THIS THING TOOK HOURS!!!!!!!! HAHAHAHAHAHAHHAHAAHAA! I am very sane and not insane. The hardest part was the pop up. Getting it for the mobile view and the desktop view gave me 50 mental breakdowns and a rock thrown at my neighbors window. It's finally over, the last newbie challenge. Can't wait for more mental breakdowns and vandalism from the future projects since they're going to be harder.
Community feedback
- @pRicard0Posted about 1 year ago
You look like me on my sanest day. I'm afraid to comment now but ok
- I think you could make the pop up disappear when the user clicks on any other part of the screen.
- Use h1 instead of h3. I recommend respecting the title hierarchy. If there is no h1, there is no h2 and so on...
- Instead of using the div for the popup, you can replace it with nav
- Don't use abbreviations in the alt attribute.
I'm going to tell you something to give you more headaches... so... be prepared.
- While the icons aren't visible, it's recommended that you also hide them from screen readers. Visually hiding it isn't enough. It's recommended to at least set
aria-hidden="true"and update with javascript.
But of course, you don't need to apply this now, I think it could get very complicated. Take your time!
Marked as helpful1
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord