Responsive Application using ReactJS

Community feedback

• 

  T

  Alex•2,010

  @AlexKMarshallPosted about 3 years ago

  This looks and works great. I only have a couple of comments.

  I'd wrap the JSON.parse call in a try/catch as it can throw. The todos should probably be in an <ul> with the todos being <li> elements.

  There are quite a few divs that pretend to be buttons. This makes them inaccessible using the keyboard. We shouldn't attach onClick handlers to non-interactive elements like divs. They should be real buttons. This applies to deleting todos, changing the theme and filtering the todos.

  The checkbox for marking a todo complete can be used by the keyboard, but it's missing a focus-visible style to show you which todo you're interacting with.

  I'm very impressed with the drag and drop being written from scratch, and it works great with a mouse. But it's also not keyboard-accessible. That would be hard to do by hand I expect. I used dnd-kit to do it.

  Marked as helpful

  1

  ---

  

  Usmonbek Rustamov•235

  @usmonbek-umarbekovichPosted about 3 years ago

  @AlexKMarshall Thank you for checking it out. I definitely consider your comments. First, I was going to use dnd, but I just wanted to challenge myself and try something hard. I didn't really think about keyboard accessibility. Thank you again, you've been very helpful

  0
• 

  favori•0

  @favori-ncryptPosted about 3 years ago

  ccol font, nice ui

  0

  ---

  

  Usmonbek Rustamov•235

  @usmonbek-umarbekovichPosted about 3 years ago

  @favori-ncrypt Thank you

  0