Design comparison
SolutionDesign
Solution retrospective
So, it gets confusing when defining the shading on the main element, it seems that shading is used, but at the same time it seems that it is not.
Community feedback
- @0xabdulkhaliqPosted over 1 year ago
Hello there 👋. Congratulations on successfully completing the challenge! 🎉
- I have other recommendations regarding your code that I believe will be of great interest to you.
CSS 🎨:
- Looks like the component has not been centered properly. So let me explain, How you can easily center the component without using
margin
orpadding
.
- We don't need to use
margin
andpadding
to center the component both horizontally & vertically. Because usingmargin
orpadding
will not dynamical centers our component at all states
- You already using
Flexbox
for layout, but you didn't utilized it's full potential. Just add the following rules to properly center the component.
main { min-height: 100vh; align-items: center; }
- Now remove these styles, after removing you can able to see the changes
main { padding-top: 10%; }
- Now your component has been properly centered
.
I hope you find this helpful 😄 Above all, the solution you submitted is great !
Happy coding!
0 - @Danish49Posted over 1 year ago
There os no use of box shadow you have set a different background colour that's why it seems to you that there is a shade in the original version.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord