@kaamiik
Posted
Hello, congratulations on completing this challenge. I have also managed to finish it. It’s impressive that you were able to accomplish this using a framework. I am currently learning React, but I haven’t yet started a project using it.
Upon reviewing your project, I noticed a few issues when viewing it on Firefox. The grid layout seems to be off, which I suspect might be a browser-related issue. Additionally, in the error state, when I enter a zero or a negative number, the outline of the input field should turn red to indicate an error. Furthermore, when changing a positive number to zero or to an error state, the reset button remains enabled. I believe it would be more intuitive if it were disabled in these cases.
Overall, this is a challenging task, especially on the JavaScript side, and I think you’ve done an excellent job. I’m sure my solution has its fair share of bugs as well. Keep up the good work and continue learning and improving! 😊
Marked as helpful
@matbac85
Posted
@kaamiik
Hello,
Thank you for your feedback and congratulations on finishing the challenge as well! It's great to hear that you found my approach using a framework impressive. Personally, I find it easier than vanilla JS.
Regarding the issues you mentioned:
Grid Layout on Firefox: I appreciate you pointing this out. I’ve reviewed the grid layout but haven't been able to pinpoint the exact issue causing the discrepancy on Firefox. Could you clarify what exactly seems off?
Error State Indicators: I have implemented a red border around the input fields when they are in an error state (e.g., when entering zero or negative numbers). This should make the error states more visible.
Reset Button Behavior: The reset button will now be disabled if the form is in an invalid state, such as when entering zero or negative numbers.
Thanks again for your detailed feedback. It’s always helpful to have another pair of eyes on the project. Keep up the great work with your learning journey in React, and feel free to reach out if you have any questions or need further assistance. 😊 I did a bit of React too but I'm a little rusty.
@kaamiik
Posted
Please, it’s my pleasure. Honestly, reviewing others’ code helps me a lot, especially your code which is very well written. Regarding the Firefox issue, I was also surprised by this problem. I’m not sure if it’s because of the grid. Most likely, the problem is with the input with id=custom because it has caused that column to occupy more space and stretch.
I’m very happy that I could help and thank you for your kindness. @matbac85