Submitted over 2 years ago
Responsive and Built with Html5, CSS, Flexbox, mobile-first workflow
@MacChristo
Design comparison
SolutionDesign
Solution retrospective
This challenge was really interesting. Any improvement feedback is highly appreciated.
Community feedback
- @ApplePieGiraffePosted over 2 years ago
Hello there, Macaulay Omoikhoje De-great! 👋
Good effort on this challenge! 👍
A few suggestions I have are,
- Adding a
max-width
to the main wrapper or container element that holds the content of the page to prevent the design from stretching out to be too wide on extra-large desktop screens. - Taking another look at the responsiveness of your site. Currently, there are some issues such as a horizontal scroll bar appearing along the bottom of the page and not all of the content is visible without scrolling left/right at around 1100px - 450px. Even if the desktop and/or mobile views of your site look good, it is important to make sure that your site looks great across all screen sizes so that as many people as possible can enjoy your work. If you’d like to learn more about how to make your site responsive, check out this helpful course.
- Avoiding setting specific heights for most of the elements in your page (especially wrapper or container elements—such as in this case, the
main
element). It's often better to simply allow the height of elements to be determined by their content (which is their default behavior) because then they will be just as high as they need to in order to accommodate what's inside them. You can always use margin or padding to add extra space around or inside those elements if desired.
Hope this helps. 😊
Keep coding (and happy coding, too)! 😁
Marked as helpful1 - Adding a
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord