Responsive and Adaptive Page using Flexboxes and Media Queries.

Community feedback

• 

  P

  Ken•4,915

  @kens-visualsPosted about 3 years ago

  Hey @cheepmanzee 👋🏻 it's me again 😅

  I have some feedback for the overall project

  • I noticed you're using a lorem text instead of the original one, I'd suggest using the original text from the initial HTML file. That way you'll preserve the design and, generally, using a "meaningful" text even in a small project like this is more welcomed than lorem.
  • Next, for the star icons, add aria-hidden="true" to all of them, because they're for decorative purposes only. You can read more about aria-hidden here.

  I hope this was helpful 👨🏻‍💻 Overall, you did a great job with responsiveness. Just one last thing, while on mobile view, make sure that the stars are on top of the text and can take the full width. I believe you can achieve this with flexbox. That's it from me, cheers 👾

  Marked as helpful

  1

  ---

  

  Valentin•290

  @cheepmanzeePosted about 3 years ago

  @kens-visuals Hey!

  Thank you for your feedback, I really appreciate it! About the starts on mobile view, I just wanted to try something new like stacking imgs with text-align: center, thought It would look nice.Well, I can always do the flex-direction: column. At least it was fun!))

  0

  

  P

  Ken•4,915

  @kens-visualsPosted about 3 years ago

  @cheepmanzee it's fine, as long as you're aware of the behavior 🙃 We're all here to learn and experiment, no pressure 👌🏻

  0