Better5afe• 850
@better5afe
Posted
Hi Maksym!
Firstly, congrats on completing this project! I hope you had fun while making it and you gained a lot of new experiece!
Please find some minor suggestions on what can be improved below:
- If you enter a future date but still within 2023, the form is submitted sucessfully and the result shows up in negative numbers (I tried it with 27.09.2023).
- In BEM technology, double dash -- suggest that the element is a modification. Therefore, instead of
app-body__inputs__box--label-dayI would useapp-body__inputs__box-label--dayand the same forapp-body__results__box--result-years>app-body__results__box-result--years. - Please change the lang attribute inside the
<html>tag to en since the app is written in English. - For better semantic, I would suggest using a
<form>tag instead of a standard section as a container for inputs. - An optimal font size set inside the
htmlselector should be 62.5% if you want to later use it to adjust elements' font size with rem or em units. - Instead of using separate
margin-topandmargin-bottomfor the same element (the same goes with padding), you can use a shorthand property:margin: 6rem 0 4rem. - Since you are working with SASS, you can use variables to store the colors. It makes them easier to use throughout the code and adjust if needed.
Overall, good job and the project is pretty solid as it is. Still, I hope you find my comment helpful.
Happy Coding! 🎃
P.S. Pozdrowienia z Polski 😉
0
Maksym• 210
@Maksio07
Posted
Hi @better5afe,
Thank you for your freedback, it was very helpful. I used all your sugestions and fixed errors in my solution and it looks much better.
P. S. Pozdrawiam serdecznie 😉
1
