Responsive age calculator app

Community feedback

• 

  Levis Kim•1,200

  @Orekihotarou-kPosted 9 months ago

  Thank you @b4n1y4. I'll make the changes and update them.

  0
• 

  Ritesh_Gupta•520

  @b4n1y4Posted 9 months ago

  Hey KB, nice take on the challenge. The design looks good overall, however the age calculation looks wrong. Please check. There are a few more things that I would suggest:

  1. values can't be negative or 0 [suggestion: define min max boundaries for the values]
  2. I see you used input type number. Maybe try to remove those spinners for a nice touch.
  3. The date shouldn't be more than current date as we are talking about age calculator and well, how can you calculate age of someone born in future.
  4. When the errors pop up, the input element shifts up. I think its a flexbox mistake. maybe try aligning contents and justify content to flex-start[ I haven't checked your code so maybe you've used something else. But this is an issue]
  5. Additional, try to develop a logic where if the value for day month year is 1, then you show "1 month" and not "1 months".
  6. For mobile layout, try increasing gap between inputs and reduce the font-size
  7. Correct the spelling of Year
  8. Add the font specified in the style-guide.md file

  You can reach me out for more details or check out my solution for this challenge. Hope it helps ✌🏻

  0