Design comparison
Solution retrospective
Please find here my solution for this project. I tried to implement the bonus task of animating the number output as well as taking leap years into consideration. However, just before submitting the solution I realized that the "animation" runs much slower in Firefox than in Chrome, but I am not quite sure why this is happening. Anyway please feel free to provide any feedback :)
Community feedback
- @arturasmckwczPosted about 1 year ago
Looks absolutely great! The code is clean and readable!
The only thing I'd like to point out to is when I type 8.9.1985 (today is 8.9.2023) it reads 37y 11m 30d instead of 38y 0m 0d. Sorry I'm not able to post a screenshot here. And after some number of tries it started reading strange things. I did recording, you may find it on Discord #random (https://discord.com/channels/824970620529279006/1098207373434302504/1149648239839158385)
0@onkelarminPosted about 1 year ago@arturasmckwcz Hi Arturas, thanks for your feedback and for pointing out the issue with the dates. I believe I fixed it now. The problem was the way the time differences between current time and entered time were calculated. I originally just subtracted the 2 timestamps and then calculated day, month and year from this difference. However, this created some inaccuracies since I had to use some average values like: 365.25 days per year, 30.4167 days per month. Instead of comparing the timestamps I now calculate the differences between entered year and current year, entered month and current month etc. directly and added some logic to it. While doing that I also realized and fixed another small bug in the animation effect, which might have been the other problem you were referring to. The updated code is on GitHub in case you wanna have a look. Thanks again for pointing this out!
0 - @sirisha9Posted about 1 year ago
That was great job. In fact I learned a lot going through your work. That way of solution presentation is pretty good. The only small thing I noticed is the cursor pointer is missing.
0@onkelarminPosted about 1 year ago@sirisha9 Thank you for the feedback and the kind words! I fixed the cursor, thanks for pointing that out :) Glad that my solution was of some value to you
0 - @aamirmasood0102Posted about 1 year ago
Great work man,your codes include the leap years part too which was not the task of this challenge.Your codes impressed me and taught me a lot of new stuff.
0@onkelarminPosted about 1 year ago@aamirmasood010 Thank you for your message and your feedback, much appreciated!
1
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord