Design comparison
Solution retrospective
I used vh or vw instead of px but I am not sure which one I should use in which situation. I want to learn css without any frameworks to get used to it.Then I'll be switching to using scss or tailwind.(What do you think? Should I just start frameworks?) And please tell me if you were building this how would you do different compared to my code. Thanks!
Community feedback
- @jgreen721Posted over 1 year ago
Nice work on this! At a glance, I'd suggest in being careful using %'s as your content container (.main) heights/widths because things can get wonky on screen size adjustments. Ive found letting padding/margin of containers/children a decent way in 'letting the size come to you' if that makes sense. So, no matter how the screen is re-adjusted your dimensions should mostly stay true. REM units seem/I believe, are your friend/popular choice but I'm not an absolute CSS authority so maybe someone else could step in and confirm/give better suggestion.
I see there is some form validation on empty inputs but it might be good experience it take it the next step and measure for valid numbers (1-12 for months, 1-31 days, etc). Ultimately dates can become a bit tricky so I wouldn't stress on absolute precision (for this) but, ya, just a suggestion. Again, nice work and happy coding! 🙂
0 - @monimunozalzatePosted over 1 year ago
Hi, great work! Dont start with any framework until you don't feel comfortable with pure css :)
0
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord