Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Responsive advice giving webpage made using react display flex

Jacks113 170

@Jacks113

Desktop design screenshot for the Advice generator app coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
  • API
2junior
View challenge

Design comparison


SolutionDesign

Solution retrospective


Behaviour on different devices, further interactivity, responsives. Constructive criticism

Community feedback

@LucSil

Posted

Hello dear,

This is not a means to put you down, and I'd really love to see you grow as a developer.

Here are some recommendations:

  • Your app isn't like the design given and lacks in a lot of areas.
  • I recommend looking up "TheNetNinja" on YouTube; he has a CSS Positioning playlist, which would bolster your skills. You can also look into his CSS playlists and code along with him.

I praise you on your effort !!! Kudos, and keep on building !!!

Marked as helpful

1

Jacks113 170

@Jacks113

Posted

@LucSil thank you will do that. And criticism is welcome and the only way to grow (by getting feedback) so I thank you.

1

Account Deleted

Hello there! 👋

Congratulations on finishing your challenge! 🎉

I have some feedback on this solution:

  • put the quote inside a <blockquote> tag instead of p to be more semantic

  • check the HTML report to fix accessiblity issues

  • add cursor pointer to button so that the user knows its clickable

i hope this is helpful and goodluck!

Marked as helpful

1

Jacks113 170

@Jacks113

Posted

@Old1337 that was good advice, thank you for the feedback. I added the things you mentioned so thank you :) .

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord