Design comparison
Solution retrospective
What did you find difficult while building the project? adjust the favicon png to green background color. Which areas of your code are you unsure of? CSS - position set for the bottom favicon and dice icon. Do you have any questions about best practices? yes, what is the best practice to set the position for the bottom favicon and dice icon.
Community feedback
- @HunterMcGrewPosted about 2 years ago
The favicon is usually a name given to describe the image that is going to be in the TAB for the window of the website. Like a logo. For this challenge the favicon shouldn't be rendered on the actual document. Just the dice. You can see how the favicon is linked in the <head></head> of the prewritten HTML file.
You made it work with absolute positioning, so good job! but I personally, dislike using absolute positioning as it can lead to problems. I like using relative positioning and setting offsets. But it's not necessarily about how we get there, it's THAT we get there. So good job! :D Each person will have their own likes and dislikes. Do what is comfortable for you.
I also noticed you are fetching the API data upon each page reload instead of making the dice a clickable button that fetches new data.
Marked as helpful0@christytanPosted about 2 years ago@HunterMcGrew thank you for your feedback!
I didn't realize that it's supposed to be a clickable icon that trigger the clickable event. Hope we have a short video instead of static image of instruction here. the button is just a button that I need to create a div and shape it to a circle combined with dice.
0@HunterMcGrewPosted about 2 years ago@christytan Yeah, you already made the proper things to be clicked, just need to make the JS for it.
I believe in the readme under "the challenge" it does say there needs to be a clickable fetch, but honestly, it's your own project and you can do it however you want. It's more about the experience and trying new things IMO. But if you were going to use it on a portfolio or anything, you would probably want to have the dice fetch new data.
Happy Coding!
Marked as helpful0
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord