Responsive Advice Generator

Community feedback

• Account deleted

  Hi there,

  it so close good job!

  • put the quote inside a <blockquote> tag instead of h1 to be more semantic

  Marked as helpful

  1

  ---

  

  Mihailo Dilparic•190

  @TheDilpPosted over 2 years ago

  @Old1337 Thank you very much! I think the big difference in the comparison comes from the quote being different since I set it up to fetch a random one on page load.

  Ah, blockquote totally slipped my mind, good point, thank you!

  1
• 

  amichno•220

  @amichnoPosted over 2 years ago

  Hi, when I change the window dimensions the border radius do not look perfect. You can use vendor-prefixed to make some css properties the same on different browsers(or you scss so it will make it automaticly).

  0

  ---

  

  Mihailo Dilparic•190

  @TheDilpPosted over 2 years ago

  @amichno That's probably because the challenge provides 375px and 1440px as the only required break points, so I left the rest of them as "continued development"

  0