Responsive Advice Generator App

Community feedback

• 

  Joanna•370

  @JoannaLapaPosted about 2 years ago

  Hi Youssef Magdy!

  My congrats on finishing the challenge! Your solution looks really good - it is responsive and you took care of all the design details included in the design file. The application works well besides the Firefox browser (I explain below). Your code is clean and short.

  Some small details that you can improve: JS:

  1. When you open your site by Firefox browser there is a bug with taking advice from API - it takes only the advice at first and after doesn't refresh it. The problem doesn't exist on other browsers. Apparently, Firefox by default looks for a matching request in its HTTP cache. If there is a match and it is fresh, it will be returned from the cache - so it doesn't change the advice for a new one. You can read more in this article on mdn.

  You can resolve it by adding {cache: no-cache} just after the URL address. I think this is a very interesting topic.

  CSS:

  1. Very little detail to consider - you repeat 3 times the code: display: flex; align-items: center; justify-content: center; I think that this is a good way to add a class dedicated for flex like eg. "flex-center" and add it to HTML together with other classes.
  2. The responsiveness of your project is really good. The only suggestion that I have is when I look at iPhone 5 size there is no margin between the container and the edges of the screen.

  I hope that my feedback was helpful, Happy coding! Joanna

  Marked as helpful

  1

  ---

  

  Youssef Magdy•160

  @youssefmagdy21Posted about 2 years ago

  Hey Joanna!

  Thank you for your feedback, it's really appreciated 🙏

  Great tip about how Firefox handles the HTTP request, i actually didn't know this before, so thank you for pointing this out. I will check the article and make sure to fix this bug in my code.

  For the CSS i actually was going to add a flex container class instead of repeating those lines of code, but apparently i forgot so thank you for pointing this out 😅 also i really appreciate your feedback about how the page displays in iPhone 5, i will make sure to fix this bug for similar screen sizes.

  Thank you for your tips and suggestions they are really appreciated 🙏⭐

  0

  

  Youssef Magdy•160

  @youssefmagdy21Posted about 2 years ago

  Hey @JoannaLapa

  Thank you again for your feedback, the issues you pointed out should be fixed now

  if you have any further suggestions they are very welcomed 🙏

  0