Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Responsive advice generator app

@TuanAnh45468

Desktop design screenshot for the Advice generator app coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
  • API
2junior
View challenge

Design comparison


SolutionDesign

Solution retrospective


Hi there, I'm Tuan Anh and this is my solution for this challenge

Built with

  • TailwindCSS
  • Javascript

Any suggestions on how I can improve my code are welcome

Thank you 😊.

Community feedback

@0xabdulkhaliq

Posted

Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

HEADINGS ⚠️:

  • This solution lacks usage of <h1> so it can cause severe accessibility errors due to lack of level-one headings <h1>
  • Every site must want only one h1 element identifying and describing the main content of the page.
  • An h1 heading provides an important navigation point for users of assistive technologies, allowing them to easily find the main content of the page.
  • So we want to add a level-one heading to improve accessibility by reading aloud the heading by screen readers, you can achieve this by adding a sr-only class to hide it from visual users (it will be useful for visually impaired users)
  • Example: <h1 class="sr-only">Advice generator app</h1>
  • If you have any questions or need further clarification, you can always check out my submission for another challenge where i used this technique and feel free to reach out to me.

.

I hope you find this helpful 😄 Above all, the solution you submitted is great !

Happy coding!

Marked as helpful

1

@Kamlesh0007

Posted

Hey there! I noticed that your React app can take some time to load, and it might be a good idea to add a loader to improve the user experience.

To add a loader in React, you can create a new component called Loader and use it to display a loading message or animation until your content has loaded. You can then conditionally render your Loader component based on the state of your app.

You need to Make it responsive also for Mobile devices. if u want u can refer my repo

Marked as helpful

0

@TuanAnh45468

Posted

@Kamlesh0007 Thank you for your feedback. However, what do you mean make it responsive for Mobile device? Can you tell me which part need to be responsive? Thank you

0

@Kamlesh0007

Posted

@TuanAnh45468 bro for devices with smaller screen like having width of 335px or below then the texts are not properly visible they are overiding the button

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord