Responsive Advice Generator

Community feedback

• 

  Travolgi 🍕•31,400

  @denieldenPosted about 2 years ago

  Hello Kerim, You have done a good work! 😁

  Some little tips to improve your code:

  • add main tag and wrap the card for improve the Accessibility
  • you can use picture tag to change image by resolution -> read here
  • remove margin-top from container class because with flex they are superfluous
  • after, add min-height: 100vh to body because Flexbox aligns child items to the size of the parent container

  Keep learning how to code with your amazing solutions to challenges.

  Hope this help 😉 and Happy coding!

  Marked as helpful

  1

  ---

  

  KerimGurbaz•100

  @KerimGurbazPosted about 2 years ago

  Hello @denielden, Thanks for your really helpful feedback... I made the changes based on your advice. you are great, thank you..

  1

  

  Travolgi 🍕•31,400

  @denieldenPosted about 2 years ago

  @KerimGurbaz you are welcome and keep it up :)

  1