Responsive Advice Generating App with HTML, CSS and JS

Community feedback

• 

  Miran Legin•680

  @miranleginPosted about 2 years ago

  Hi Gabriela,

  congratulations on completing this challenge!

  I have couple of suggestions to make this even better in my opinion.

  1. styling elements based on their name instead of css value is not flexible because i would suggest that you use <q> instead of <h2> for the quote itself. Not only it is better from semantic point of view but the added benefit is that you get quotation marks by default. More info here
  2. remove the height completely like previous commenter explained because when working with dynamic data you can never know how much of a text there is

  Keep coding!

  Cheers, Miran

  Marked as helpful

  1
• 

  P

  Dave•5,295

  @dwhensonPosted about 2 years ago

  Hello Gabriella,

  Lovely job here! In response to your button challenge here is what I would do:

  1. Remove the fixed height from the square-background. I would suggest in general to avoid setting heights if possible and use content, and if needed padding, to create a larger element.
  2. On the button, remove the absolute positioning, and add transform: translateY(50%), and that should do it.

  Transforms to position an element are great as they don't impact performance, and unusually for CSS, the percentage refers to the element being targeted, not its parent.

  So in this case we are telling the element to move down 50% of its height. Which is about where you want it I think? This also avoids hard coding pixel values which can make responsive design pretty tricky.

  Hope this helps and nice work on the fetch call. Nice that you got some JS working!

  Cheers Dave

  Marked as helpful

  1