Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

responsive accordion page using HTML, CSS and Javascript

@Josep-Ocana

Desktop design screenshot for the FAQ accordion coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


What are you most proud of, and what would you do differently next time?

I'm proud of create my js solution using atributes in HTML for screen readers.

What challenges did you encounter, and how did you overcome them?

Creating the js code and HTML with attributes for screen readers, although it was not very difficult, I had a little trouble creating the html tags with attributes for screen readers.

What specific areas of your project would you like help with?

Is correct the way I create my js? or are there another best way?

Community feedback

@R3ygoski

Posted

Hello Josep, congrats for conclude this challenge, it's very good!

About your doubt, yes, your JS is very fine, there isn't any great mistake or error. And there's no need to use e.preventDefault(), we most time use this with <form> so it don't reload the page. But in your case, I see no reason to use it.

And this was a good pratice, use aria in your project, this highly increase the accessibility of your page, I really need to do this too.

Well, congrats, your project it's really good, keep practicing and improving your skills, if something I said was unclear, please, comment below and I will try to help in the best possible way.

Marked as helpful

0

@Josep-Ocana

Posted

Hi Bernardo! I'm really glad you like it!!!!

Thank you very much, you are absolutely right, in this project the e.preventDefault() is not necessary. I've create several forms and I had to use them , although, in this time, I've got confused and I've put it. I have already fixed it .

Thanks also for your feedback about the aria in the code I want to emphasize learning the code for screen readers as I find it necessary for everyone to be able to see all the content on the internet without having accessibility problems.

Thanks again for commenting, it has helped me to improve.

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord