Responsive accordion FAQ component - Vanilla JS, & CSS5
Design comparison
Solution retrospective
Hi and thank you for reviewing my solution. I am just starting with FrontEnd development and I really enjoy it.
I had various problems with this seemingly ease challenge. First of all, the assets were not centered, so I constantly had to rearrange everything with position: relative;
.
Secondly I have a small problem on the mobile version, where the background of the logo is not centered. This is, again, happening due to not centered assets.
I really enjoyed working on the js with this challenge. This component is letting only one item to stay open, while animating various other stuff at the same time! Any help, about my code style, or anything else really is much-much appreciated!
-Billy.
Community feedback
- @ApplePieGiraffePosted almost 4 years ago
Greetings, Vasiles Petrides! 👋
Congratulations on completing your first Frontend Mentor challenge! 🎉 Well done on this one! 👍 I like the animation you added to the floating cube (and how it slides to the left when a FAQ is opened). 😀
I'd just like to suggest,
- Switching to a mobile-friendly layout a little sooner to prevent a horizontal scroll bar from appearing along the bottom of the page right before the layout changes from desktop to mobile.
Keep coding (and happy coding, too)! 😁
1@vpetridisPosted almost 4 years ago@ApplePieGiraffe Hi and thank you for your reply. I will fix the horizontal scroll bar, I forgot to do it before submitting my challenge. Thank you again!
1 - @abhik-bPosted almost 4 years ago
Hi Billy 👋
Fantastic job on this challenge , I loved the animations and responsiveness 💯, It seems perfect
** I have a small problem on the mobile version, where the background of the logo is not centered : ** Giving
right: 2.5%
might fix thatI would highly recommend you to check APG's solution
Welcome to Frontend development , Happy coding 😇
1@vpetridisPosted almost 4 years ago@abhik-b Thank you for the help! I liked the APG's solution with the bouncing box, so I figure it out how to implement it with a library. On the other hand, the solution you are suggesting is not fully responsive. Mine is on every viewport. I thought we shouldn't make it scrollable 😢.
Then again, I will not work anymore on centering stuff on every media query! Have a good one.
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord