Submitted about 2 years ago

Responsive

webFerrol• 40

@webferrol

Preview site(opens in new window)View code(opens in new window)

This is a solution for...

QR code component

HTML
CSS

1newbie

View challenge

Design comparison

SolutionDesign

Community feedback

Kawsar Ahmed Fahad• 2,680

@faha1999

Posted about 2 years ago

Hello, webFerrol Congratulations on finishing this project. It's lovely and great on the whole! Just a little tip:

You might want to use semantic tags like the <main> to wrap your code, instead of div. like

<main class="card">
</main>

I saw in the structure.css that sometimes you use px & rem. To optimize your speed when resizing fonts for various displays and devices, substitute rem or em rather than px. These components work better to improve the accessibility of your website. REM applies to all sizes, not just the font size.

I hope it will work. Happy coding.

Marked as helpful

Lucas 👾• 104,440

@correlucas

Posted about 2 years ago

👾Hi @webferrol, congratulations on your first solution!👋 Welcome to the Frontend Mentor Coding Community!

Great solution and a great start! From what I saw you’re on the right track. I’ve few suggestions for you that you can consider adding to your code:

The HTML structure is fine and works, and you can reduce at least 20% of your code by cleaning the unnecessary elements, you start cleaning it by removing some unnecessary <div>. For this solution you wrap everything inside a single block of content using <div> or <main> (better option for accessibility) and put inside the whole content <img> / <h1> and <p>.

<body>
<main>
<img src="./images/image-qr-code.png" alt="QR Code Frontend Mentor" >
 <h1>Improve your front-end skills by building projects</h1>
<p>Scan the QR code to visit Frontend Mentor and take your coding skills to the next level</p>
</main>
</body>

✌️ I hope this helps you and happy coding!

Marked as helpful

webFerrol• 40

@webferrol

Posted about 2 years ago

Thank for your suggestions. I'm right width you.

Please log in to post a comment

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord