Responsive 4 card feature section using CSS Grid & Flexbox

Community feedback

• 

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted almost 3 years ago

  Greetings, Yunie08! 👋

  Nice work on this challenge! 🙌 Overall, your solution looks pretty good and responds well! 😀

  I suggest,

  • Using a single heading tag for the title of the page. That's because the title of the page is really a single title (not two separate titles) and so just one heading tag should be enough. You can style the second half of the title differently by wrapping it a span tag and targeting that span in your CSS to override its styles.
  • Adding a max-width to the feature cards on the page so that they aren't so wide when the layout of the site first switches from desktop to mobile.
  • Perhaps using article tags for the feature cards in this solution since they are self-contained elements. IDK... that might make your HTML a little more semantic?

  Hope you find those couple of tips helpful. 🙂

  Keep coding (and happy coding, too)! 😁

  Marked as helpful

  0
• 

  Ambre•170

  @Yunie08Posted almost 3 years ago

  Hello AplePieGiraffe !

  Thanks a lot, it really helps!
  I'll definitely look into the suggestions you made and modify my code. The second point was kind of a choice though, but indeed probably not the wisest one. 😅

  Happy codind to you too, and thanks again!

  0