Responsive 3column-preview-card-component

Community feedback

• 

  Travolgi 🍕•31,400

  @denieldenPosted almost 3 years ago

  Hi Naveen, I took some time to look at your solution and you did a great job!

  Also I have some tips for improving your code:

  • remove all margin from App
  • add max-width: 22rem; to card class
  • try to use flexbox to the body for center the card. Read here -> best flex guide
  • after add min-heigth: 100vh to body because Flexbox aligns to the size of the parent container

  Tip of graphic design: With font-family:" Big Shoulders Display ", cursive the browser will use the Comics Sans font when it doesn't find the first font indicated (you can seen during loading) ... for the designer it's a really awful font!

  • I would rather replace it with a font-family:" Big Shoulders Display ", sans-serif much more similar to the primary font.

  Overall you did well :)

  Hope this help and happy coding!

  Marked as helpful

  2

  ---

  

  Naveen Ongole•80

  @Naveen39OPosted almost 3 years ago

  @denielden Thanks for taking time to review the solution and providing some detailed improvements. This would help me a lot in improving my code and in becoming better front end developer.

  1
• 

  Hexer•3,660

  @EmmanuelHexerPosted almost 3 years ago

  Great work overall man.

  1