Design comparison
Solution retrospective
I used Semantic HTML5, BEM, SCSS, Flexbox, CSS Grid and Media Queries.
Any feedback on these topics, good practices or others aspects is welcome.
Community feedback
- @FluffyKasPosted about 3 years ago
Hey, it's a great looking solution! Two small things I'd add: The attribution text overlaps with the component in mobile view. Not sure whether this was your intention but perhaps you could change this. You could also add some transitions for the button hovers. Otherwise really good job!
Marked as helpful2@jmpevzlaPosted about 3 years ago@FluffyKas Hello, Thank you for you feedback. Yes the attribution text was intentional, I will can simply remove it, and the hover effect works in desktop view, in mobile works when press the button (active).
0@FluffyKasPosted about 3 years ago@jmpevzla I didn't say it doesn't work, I only said you could add some transition to it to make it look bit smoother ^^
Marked as helpful1 - @ZenCode95Posted about 3 years ago
Wow, this an outstandingly well put together solution! Capital job, sir. Well done.
Marked as helpful1 - @bassha6Posted about 3 years ago
Overall its good but try to add some hover effect
Marked as helpful1@jmpevzlaPosted about 3 years ago@bassha6 Hello!, thank you for you feedback, The hover works in desktop view, in mobile works only when press the button.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord