Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Responsive 3-column preview card using grid

@mbonamensa

Desktop design screenshot for the 3-column preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


I am happy to hear feedback on best practices. Also, did you use flexbox or grid? Why did you choose one over the other in solving this challenge? I'd want to hear your perspectives.

Community feedback

@MelvinAguilar

Posted

Hi @mbonamensa πŸ‘‹, good job on completing this challenge! πŸŽ‰

I like this solution for the challenge. Here are a few suggestions I've made that you can consider in the future if you're looking to improve the solution further:

  • The <h1> element is the main heading on a web page. There should only be one <h1> tag per page. The HTML Section Heading elements (Reference). This case requires that SUVS, SEDANS, and LUXURY be <h2> elements.
  • The Learn More elements should be anchor tags and not buttons because they redirect to another part of the page.
  • Instead of using pixels in font size, use relative units of measure like rem or em. The font size in absolute length units (px) does not allow users with limited vision to change the text size in some browsers. Reference.

I hope those tips will help you.

Good job, and happy coding!

Marked as helpful

0

@mbonamensa

Posted

@MelvinAguilar These are really great tips! On the anchor tags and buttons, is it advisable to use both? As in wrap the buttons in the anchor tag or remove the button element entirely and style the anchor tag to look like buttons?

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord