Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Responsive 3column preview card component

Benevolent 490

@bene-volent

Desktop design screenshot for the 3-column preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


  • Have to be complete honest, using CUBE CSS methodology, has made my code more readable for me and easy to implement. I know what is happening exactly where.
  • I loosely / moderately follow CUBE-CSS to make use of compositions to create layouts, utility classes and block components.
  • I have been using Sass to create utility classes as it was very tedious to make them by hand.

Any recommendation is appreciated

Community feedback

@0xabdulkhaliq

Posted

Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

LACK OF HEADING ⚠️:

  • This solution lacks usage of <h1> so it can cause severe accessibility errors due to lack of level-one headings <h1>
  • Every site must want only one h1 element identifying and describing the main content of the page.
  • An h1 heading provides an important navigation point for users of assistive technologies, allowing them to easily find the main content of the page.
  • So we want to add a level-one heading to improve accessibility by reading aloud the heading by screen readers, you can achieve this by adding a sr-only class to hide it from visual users (it will be useful for visually impaired users)
  • Example: <h1 class="sr-only">3-column preview card component</h1>
  • If you have any questions or need further clarification, you can always check out my submission for this challenge where i used this technique and feel free to reach out to me.

.

I hope you find this helpful 😄 Above all, the solution you submitted is great !

Happy coding!

0

Benevolent 490

@bene-volent

Posted

@0xAbdulKhalid Thanks for the recommendation. I just intuitively leave out h1 because in my mind, I always think that these are going to be components and I leave out h1 without even knowing.🙂🙂 But yes, as you said accessibility is a something we should keep in mind. Thanks

0

@0xabdulkhaliq

Posted

@bene-volent Glad you found it helpful ! 🤠

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord