Responsive 3-column preview card component

Community feedback

• 

  バレンタイン 😈•64,170

  @VCaramesPosted about 2 years ago

  Hey @KristinaRadosavljevic, some suggestions to improve you code:

  • Implement a Mobile First approach 📱

  With mobile devices being the predominant way that people view websites/content. It is more crucial than ever to ensure that your website/content looks presentable on all mobile devices. To achieve this, you start building your website/content for smaller screen first and then adjust your content for larger screens.

  • Wrapping each card in a Section Element works but arguably the Article Element might be a better choice since each card represents a complete, or self-contained, section of content that is independently reusable.

  • The car images/icons serve no other purpose than to be decorative; They add no value. Their Alt Tag should left blank and have an aria-hidden=“true” to hides it from assistive technology.

  • To improve the accessibility of your content, you wan to to use em instead of px for you media queries. By using px your assuming that every users browser (mobile, tablet, laptop/desktop) is using a font size of 16px (this is the default size on browser). Em's will help with users whose default isn't 16px, which can sometimes cause the your content to overflow and negatively affect your layout.

  More Info:

  https://betterprogramming.pub/px-em-or-rem-examining-media-query-units-in-2021-e00cf37b91a9

  https://uxdesign.cc/why-designers-should-move-from-px-to-rem-and-how-to-do-that-in-figma-c0ea23e07a15

  Happy Coding! 👻🎃

  Marked as helpful

  0

  ---

  

  Kristina Radosavljevic•380

  @KristinaRadosavljevicPosted about 2 years ago

  @vcarames Thanks for taking the time to review my solution and for the comments :)

  0
• 

  Lucas 👾•104,340

  @correlucasPosted about 2 years ago

  👾Hello @KristinaRadosavljevic, Congratulations on completing this challenge!

  Great code and great solution! I’ve few suggestions for you that you can consider adding to your code:

  1.Your solution seems fine, you did a really good job wrapping the content for these 3 cards. Something you can improve here is to use a single class to manage the content that is mostly the same for the 3 cards (paddings, colors, margins and etc) and another class to manage the characteristics that are different (colors and icon), this way you'll have more control over then and if you need to change something you modify only one class.

  2.Use max-width: 100% for the cards in the mobile version to allow the cards grow 100% of the width considering the paddings and avoid to have a lateral gap (limited by a fixed width).

  ✌️ I hope this helps you and happy coding!

  Marked as helpful

  0

  ---

  

  Kristina Radosavljevic•380

  @KristinaRadosavljevicPosted about 2 years ago

  @correlucas Thanks for reviewing my solution and for the comments! :)

  1