Responsive 3-column card review

Community feedback

• 

  Adriano•38,330

  @AdrianoEscarabotePosted about 2 years ago

  Hi Konstantin Christ, how are you?

  I really liked the result of your project, but I have some tips that I think you will enjoy:

  If we see how the layout is behaving at higher resolutions, with the help of google dev tools, we will see that it is stretching a lot, to solve this we can use a max-width with the value we want the content to stop growing and to center use margin: 0 auto;

  Instead of putting the css, in the body, prefer to put it in a separate file! in larger projects, the css ends up taking up a lot of space!

  The rest is great!

  I hope it helps... 👍

  Marked as helpful

  0
• 

  Mahdi Aljaza'iri•250

  @MahdiAljazairiPosted about 2 years ago

  I just realized something that confused me for a bit. When you submitted your solution, you put a link to a commit instead of the link of the repository itself.

  Click the three dots to the right of the name of the solution and choose 'Edit solution'. Then change the Repository URL field to (https://github.com/Konstantinchrist/3-col-responsive-site), and click Update Solution.

  It's not that big of a problem, but it better be avoided in the future.

  0
• 

  Mahdi Aljaza'iri•250

  @MahdiAljazairiPosted about 2 years ago

  The corners of the divs inside of main are just flowing outside. The most straightforward solution is adding "overflow: hidden;" to main inorder to hide anything that overflow out of it.

  Also, I would suggest putting the styles in an external file, rather than in a style tag. This is better both for readability and maintainability.

  EDIT: Each property that transition applies to should be specified separately in a comma-separated list:

  button {
    transition: color padding border 150ms;               /* Wrong */
    transition: color 150ms, padding 150ms, border 150ms; /* Correct */
  }
  

  0

  ---

  

  Konstantin Christ•450

  @KonstantinchristPosted about 2 years ago

  @MahdiAljazairi thanks I didn't realize that

  0

  

  Mahdi Aljaza'iri•250

  @MahdiAljazairiPosted about 2 years ago

  @Konstantinchrist You're welcome bro

  0