Design comparison
Solution retrospective
My 4th project for my week 3!
I tried to code the mobile design first because according to some people in this community that it is a good practice to do mobile first before it goes to larger device. So.. I'm not sure if i did it correctly.
Please feel free to comment if you see any minor/major issue! Thank you so much!! <3
Community feedback
- @HashimAlSadahPosted over 2 years ago
Hi @pbitonga17, congrats on completing this challenge. Your code looks clean and the website is responsive, there is nothing to be criticized, you might want to add some margins to the main container or padding to the body to make sure that the edges of the page do not touch the main container when resizing the browser window.
Also you have one accessibility issue, where you must have headings in your html code and you start form h1, h2, h3...etc. So, in you case you must have at least one <h1></h1>.
Other than that, you have done an amazing job. keep Coding and keep doing mobile first :).
0
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord