Responsive 3 Column Preview Card using CSS Grid

Community feedback

• 

  Thomas Burette•190

  @tburettePosted 9 months ago

  The result looks nice. It doesn't exactly match the given design and that's okay! (Adjusting a layout to closely match the given challenge is a lot of time for little payoff.)

  In the HTML:

  • There is an unclosed HTML comment at the end
  • <div class="attribution"> could be a <footer
  • you used an <h3> for the link/button. Isn't there an HTML that would be a better fit?

  In the CSS:

  • When the viewport is just above 830px part of the content is not visible and there is horizontal scrolling. There seems to be some kind of mixup in your media queries (@media).
  • You could implement the effect on the button when it is active (see design/active-states.jpg)

  Marked as helpful

  0

  ---

  

  P

  Katlego Makama•40

  @KatMahnPosted 9 months ago

  @tburette Thank you very much for the feedback

  0