Design comparison
Solution retrospective
Having a lot of fun doing theese excercises :) Any improvements and suggestions are welcome.
Community feedback
- @rayaattaPosted 10 months ago
Hello Darijo Šalković, congratulations on completing this challenge 🎉
I have two suggestions that might help you. 1 since the car icons are only decorative its alt attribute should be empty .
"Images with no semantic meaning—such as those which are solely decorative—or of limited informational value, should have their alt attributes set to the empty string (""). " - Mdn webdocs
You can check out this article.
2 I noticed you have two
h1
s in your code. Here's a quick guide on how to use them:The
<h1>
to<h6>
tags are used to define HTML headings.<h1>
defines the most important heading.<h6>
defines the least important heading. Only use one<h1>
per page - this should represent the main heading/subject for the whole page. Also, do not skip heading levels - start with<h1>
, then use<h2>
, and so on. You can then style them in you css.Unlike what most people think, it's not just about the size and weight of the text It is about maintaining a clear and consistent hierarchy through out the document
3 Make your html more semantic.
div
s do not carry any semantic value. They are used solely for decorations. You should replace some of them with tags such as<article>
and<section>
You can find out more about these tags and more in this article📑.I hope this helps 🙃
Otherwise nice solution 👏
Marked as helpful1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord