Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Responsive 3 column preview card component

@zhansayatazhibayeva

Desktop design screenshot for the 3-column preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


What are you most proud of, and what would you do differently next time?

Did faster than other projects

What challenges did you encounter, and how did you overcome them?

easy project in comparison to other projects

What specific areas of your project would you like help with?

Any kind of feedback would be helpful

Community feedback

@VCarames

Posted

Hey there @zhansayatazhibayeva! 👋 Here are some suggestions to help improve your code:

  • Every site should ALWAYS have ✅ a main element not only for semantic purposes but also to help assistive technology find the main content of your content. For this challenge, it will serves as the component’s container ⚠️.
  • In this specific challenge, the icons serve a purely decorative purpose. So, it is best to leave their alt tag blank (alt="") to signal to screen readers that these elements should be disregarded.
  • The headings in your component are being used incorrectly❌. Since the h1 heading can only be used once ⚠️, it is always given to the heading with the highest level of importance. This component has three headings of equal importance, so the best option would be to use an h2 heading ✅ since it is reusable and it will give each heading the same level of importance.
  • ALWAYS Implement a "Mobile First" approach 📱 > 🖥

Mobile devices are now the dominant 👑 way in which people browse the web. So when building your content, you will start building with small screen sizes (starting at 320px) and work your way to larger screens using min-width.

<Happy Coding/>! 👾

Marked as helpful

1

@zhansayatazhibayeva

Posted

@VCarames thank you for your valuable feedback!

1
P

@JMBeltranDev

Posted

In the hover you can use <outline> instead of <border> so that the card does not resize

.luxury button:hover{
    background-color: hsl(179, 100%, 13%);
    color: #fff;
    border: 1px solid #fff;

}

.luxury button:hover{
    background-color: hsl(179, 100%, 13%);
    color: #fff;
    outline: 1px solid #fff;

}

Marked as helpful

1

@zhansayatazhibayeva

Posted

@JMBeltranDev I also noticed it but didn't know how to correct it. Thank you!!!

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord