Responsive 3 column preview card component

Community feedback

• 

  PhoenixDev22•16,950

  @PhoenixDev22Posted about 2 years ago

  Hello

  Congratulation on completing this challenge. Excellent work! I have few suggestions regarding your solution, if you don't mind:

  HTML

  • About <h1>it is recommended not to have more than one h1 on the page . Multiple <h1>tags make using screen readers more difficult, decreasing your site’s accessibility.

  • You can add a <h1> with class="sr-only" (Hidden visually, but present for assistive tech).

  • In this challenge , the images are much likely to be decorative. For any decorative images, each img tag should have empty alt="" as you did and aria-hidden="true" attributes to make all web assistive technologies such as screen reader ignore those images .

  • What would happen when the user click those learn more? In my opinion, clicking those "learn more" would likely trigger navigation not do an action so button elements would not be right. So you should use the <a> only. For future use , it's a good habit of specifying the type of the button to avoid any unpredictable bugs.

  • Links are not crawlable.You can read more here to solve this for the moment add the href with the #: <a href=”#”> ..</a>

  Overall, Your solution is good. Hopefully this feedback helps.

  Marked as helpful

  0

  ---

  

  Christian•70

  @meme-devPosted about 2 years ago

  @PhoenixDev22 noted thank you <3. I will do this in the next challenges.

  1

  

  PhoenixDev22•16,950

  @PhoenixDev22Posted about 2 years ago

  @meme-dev Glad to help. Happy coding!

  0
• 

  Lucas 👾•104,400

  @correlucasPosted about 2 years ago

  👾Hello Christian, congratulations for your new solution!

  Your solution is just great, the cards are beautiful and fully responsive, the media query are fine. The only thing you really need to fix here is the semantics replacing the card div with something more semantical as <article> or section. Maybe replace the relative unit px with rem for a better performance between different screen sizes.

  The rest is just perfect bro!

  👋 I hope this helps you and happy coding!

  0

  ---

  

  Christian•70

  @meme-devPosted about 2 years ago

  @correlucas thanks man noted! <3

  1