Responsive 3 column card using flexbox

Community feedback

• 

  Nicki•170

  @Nickil13Posted over 2 years ago

  Nice work! Your code is organized and easy to read.

  Some things you could do to improve:

  1. You can use CSS custom properties instead of hardcoding variables like colours. Makes it easy if you wanted to change the colour, so you don't have to go through and change each one at a time.

  2. Setting max-width on your paragraphs or container so the cards don't get too wide on larger screens.

  Marked as helpful

  0

  ---

  

  Cliff Harris•10

  @clearhasPosted over 2 years ago

  @Nickil13 Thanks. I do not know about about custom properties yet but it was a pain the neck writing the code for different states and colors. I think i only set max width on the layout to 80% and nothing for the paragraphs. It is a bit hard judging size as I am doing this on my laptop with multiple tabs open. I only startedd learning a month ago and just stumbled upon this website, seems like a great learning tool. Thank you for your help.

  0
• 

  Michael•300

  @Mfried95Posted over 2 years ago

  Id recommend changing @media screen and (max-width: 375px) to 390px or a-little higher. I usually use iphone 12 pro dimensions on inspect view, as max-width for mobile.

  Marked as helpful

  0

  ---

  

  Cliff Harris•10

  @clearhasPosted over 2 years ago

  @Mfried95 Thanks, you're right. I put the media query @ 375px bc it mentioned something in the info about 375px and 1440px.

  0