Design comparison
SolutionDesign
Solution retrospective
Any feedback is welcome.
Community feedback
- @mattstuddertPosted over 3 years ago
Nice work on this challenge, Tim! Your solution looks really good. I've got a couple of small suggestions:
- I'd recommend add
alt=""
to yourimg
elements. You've left thealt
attributes off at the moment, which can make screen readers read out the file path, which isn't helpful at all. These images don't add context to the content, so a blankalt
attribute will ensure screen readers skip the images. I'd always recommend having a single media query for each breakpoint at the bottom of the file in CSS. This will clean up your code a bit and make things more manageable. If you ever start using Sass, you'll see that you can nest media queries, which is very helpful. But with plain CSS, I'd recommend keeping them at the bottom of the file.
I hope that helps! Keep up the great work! 👍
0 - I'd recommend add
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord