Responsive 3 card preview component

Community feedback

• 

  T

  Josh•400

  @burrijwPosted over 1 year ago

  Hey, good start!

  There's nothing wrong with using an "extra" div if it has a purpose. Ain't nothing wrong with a div as long as you are using it with intent. You actually do need some kind of wrapper element around the three sections so that you can change the way they are laid out based on the screen. You want them stacked vertically on mobile and horizontally on desktop, so you need some way of controlling that. I'd use flexbox, personally.

  • Make sure you have all your primary page content in a <main>.
  • Use a <footer> for the attribution.
  • Try setting the border-radius on the wrapper with overflow set to hidden instead of trying to manage the border-radius of each individual card.

  Good luck! Refactor this and submit it again! 😄

  Marked as helpful

  2

  ---

  

  Derion Williams•20

  @whoisderionPosted over 1 year ago

  @burrijw

  Hey thanks for the awesome response,

  It makes sense that purposeful divs are okay. Also I was able to implement the changes that you mentioned which helped to pass the tests and get much closer to the design. That last tip about the border radius is especially helpful and will keep that in my toolbox as I work on more complex designs.

  Thanks again and have a great day :)

  0