Design comparison
SolutionDesign
Solution retrospective
I had to give a min-width of 30ch. because the layout would break and everything go out of alignment, can someone explain me why ? and how to maintain the alignment without the min-width of 30ch?
Community feedback
- @correlucasPosted about 2 years ago
👾Hello @DomilsonFirmino, Congratulations on completing this challenge!
Great code and great solution! I’ve few suggestions for you that you can consider adding to your code:
- The icon doesn’t have an important role when you think about semantics and the html structure. So you can add
aria-hidden=“true”to avoid it being found and read in the accessibility mode/screen readers. These are only decorative items. - Use
max-width: 100%for the cards in the mobile version to allow the cards grow 100% of the width considering the paddings and avoid to have a lateral gap (limited by a fixed width).
✌️ I hope this helps you and happy coding!
Marked as helpful1@DomilsonFirminoPosted about 2 years ago@correlucas Thank you, i will try to investigate more about accessibility i didn't know about that property for the icon, thanks again for the tips it will help me improve
0 - The icon doesn’t have an important role when you think about semantics and the html structure. So you can add
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord