Design comparison
Solution retrospective
Hello, world!
Community feedback
- @Islandstone89Posted 9 months ago
HTML:
-
The icons should be placed at the top of the HTML of the card, not at the bottom.
-
"Learn More" would navigate to another page, hence it is not a button but a link.
-
.attribution
should be a<footer>
, and its text must be wrapped in a<p>
.
CSS:
-
It's good practice to include a CSS Reset at the top.
-
Add around
1rem
ofpadding
on thebody
, so the card doesn't touch the edges on small screens. -
Remove
height
onbody
. -
To center the card container horizontally and vertically, use Flexbox on the body:
display: flex; flex-direction: column; justify-content: center; align-items: center; min-height: 100svh;
-
Remove the
padding
on the card container. Give it amax-width
of around50rem
, so it doesn't get too wide on larger screens. -
Remove
margin
,width
andheight
on the cards. -
font-size
must never be in px. This is bad for accessibility, as it prevents the font size from scaling with the user's default setting in the browser. Use rem instead. -
letter-spacing
must also never be inpx
. -
Media queries must be in rem.
Marked as helpful0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord