responsiv e landing page with CSS(Sass) HTML only (no javascript)
Design comparison
Solution retrospective
Hello! π My first challenge on FrontEnd Mentor π₯³ππΎ I'm still learning and all feadback ould be appreciated. Thanks π€
Community feedback
- @OlehTovkaniukPosted about 4 years ago
Wow, I like it. Text animation is cute. The container doesn't change it sizes when I click a dropdown. Though you have some adaptivity twerks at 1024x1366 resolution(iPad Pro resolution). You can fix it if you want π.
3@JulianaOliveiraMeloPosted about 4 years agoHi @OlehTovkaniuk π Thanks for notice the ipad problem. I think i managed to work around so that it doesent look so ugly π thakns again for the feedback π
1 - @tedikoPosted about 4 years ago
Hello, Juliana Oliveira Melo! π
Congratulations on finishing your first project here! Your solution responds well. I like the animation you add on tabs. What i can suggest is:
- Try not to repeat your HTML code with image for each arrow. Easier way around is to use pseudo element
::before
on your.question-group
. Set it toposition: relative
and your pseudo element asposition: absolute
. Put your image usingcontent: url(image.jpg)
. - A label should be used as a caption and does not require heading elements. I would remove
h3
elements from your labels. This way you get rid of HTML issues errors.
Good luck with that, have fun coding! πͺ
3@JulianaOliveiraMeloPosted about 4 years agoHi @tediko π Thank you for the comments. They were very useful. I manage to solve the html issues and use the :after with an image has content. Thanks a lot π
1 - Try not to repeat your HTML code with image for each arrow. Easier way around is to use pseudo element
- @ApplePieGiraffePosted about 4 years ago
Hey, Juliana Oliveira Melo! π
Congratulations upon completing your first Frontend Mentor challenge! π
I think you've done a good job on this challenge! Like OlehTovkaniuk mentioned, the animation on the body text of the FAQs is pretty cool! π
Keep coding (and happy coding, too)! π
2@JulianaOliveiraMeloPosted about 4 years agoHi @ApplePieGiraffe π Thanks for the feedback. I appreciate it π
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord