Responsite Social Proof Section using flexbox want your feedback.

Community feedback

• 

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted over 3 years ago

  Hey there, Vitor Lacerda! 👋

  Good work on this challenge! 👍

  A few things I suggest are,

  • Adding a max-width to the review boxes and the testimonial boxes so that they aren't too wide when the layout first changes from desktop to mobile.
  • Setting the alt attribute of the star icon images to an empty string so that screen readers don't the read the alt text for each star icon out loud (which is unnecessary and can be a little annoying).
  • Allowing the height of the testimonial boxes to be determined by its content (rather than giving it a fixed height) so that there's always just enough space for the text inside.

  I usually use rem as a unit for things like dimensions and sizes. It's considered a good practice because it is based on the root font-size of the document and will scale up/down if the user ever changes the default font-size of their browser for accessibility reasons. 😉

  Keep coding (and happy coding, too)! 😁

  1

  ---

  

  Vitor Lacerda•150

  @vitorlfariaPosted over 3 years ago

  @ApplePieGiraffe Thanks for the feedback! Now i know why i should use rem and em. But i still struggle to convert from px to rem, but i think it will come with practice.

  Keep coding and happy coding!

  0