Responsice Flex Basis QRCode-Improvement Guidence Appreciated🤝

Community feedback

• 

  Melvin Aguilar 🧑🏻‍💻•61,140

  @MelvinAguilarPosted 10 months ago

  Hello there 👋. Good job on completing the challenge !

  I have some suggestions about your code that might interest you.

  HTML 🏷️:

  • Use the <footer> tag to wrap the footer of the page instead of the <div class="attribution">. The <footer> element contains information about the author of the page, the copyright, and other legal information.

  • Since this component involves scanning the QR code, the image is not a decoration, so it must have an alt attribute. The alt attribute should explain its purpose. e.g. QR code to frontendmentor.io

  CSS 🎨:

  • Use min-height: 100vh instead of height. Setting the height to 100vh may result in the component being cut off on smaller screens, such as a mobile phone in landscape orientation.

  I hope you find it useful! 😄 Above all, the solution you submitted is great!

  Happy coding!

  Marked as helpful

  2

  ---

  

  Mr-Khaira•30

  @Mr-KhairaPosted 10 months ago

  @MelvinAguilar

  Thanks I appreciate your review.

  1
• 

  Daniel 🛸•44,250

  @danielmrz-devPosted 10 months ago

  Hello @Mr-Khaira!

  Your solution looks very good!

  I have a few suggestions for improvement:

  • Use min-height: 100vh; instead of height: 100vh; on the container. Using heigh:100vh can cause some bugs and depending on the size of the screen, part of the content might be cut off.

  • For semantic reasons, and since that is the main title of the screen, you can replace the div.card-text-header with h1.card-text-header.

  The <h1> to <h6> tags are used to define HTML headings. <h1> defines the most important heading. <h6> defines the least important heading. Only use one <h1> per page - this should represent the main heading/subject for the whole page. Also, do not skip heading levels - start with <h1>, then use <h2>, and so on.

  I hope it helps!

  Other than those details, you did an excelent job!

  Marked as helpful

  1

  ---

  

  Mr-Khaira•30

  @Mr-KhairaPosted 10 months ago

  @danielmrz-dev

  Thanks, I appreciate your suggestions.

  1