Skip to content
Submitted 5 months ago

Responsibe Recipe Page on React using CSS Modules with BEM

#react
orbdev1•130
@orbdev1
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Recipe page
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

What are you most proud of, and what would you do differently next time?

I think use CSS Modules with React. I will use Tailwind CSS soon

What challenges did you encounter, and how did you overcome them?

Use prop types correctly, i needed read about Proptypes's types and use cases

What specific areas of your project would you like help with?

About the naming on BEM and PropTypes :)

Community feedback

  • Thomas Weitzel•170
    @thomasweitzelPosted 5 months ago

    Your solution is a really nice React application. I like how you have broken up the code in multiple components. That makes the structure of the project crystal clear. Good job!

    Maybe you want to consider two small improvements?

    • The breakpoint at 375px doesn't make sense because most of the content is not readable by then. Maybe have the breakpoint at 750px, but no later than 690px. I believe the 375px comes from the fact that the mobile design screenshot was captured that way.
    • The table with the nutrition data has an additional horizontal ruler/line after the last row that is not in the design. You could apply the class .recipe-card__nutrition-table-tr conditionally for every <tr> except the last one. In that case it would be helpful if nutrition was an array - not an object.

    Anyway, I really like how you have structured your app! Again: great work!

    1

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord