@vanzasetia
Posted
👋 Hi Júlio Césa!
Quick feedback for this solution:
- To make the
card
perfectly in the middle of the page, you can make thebody
element as a flexbox container.
/**
* 1. Make the card vertically in the middle
* and allow the body element to grow
* if needed
*/
body {
display: flex;
align-items: center;
justify-content: center;
min-height: 100vh; /* 1 */
}
- There's no need to have two separate stylesheets. What's the reason of doing that?
- About the eye icon and the overlay, you can check my solution and read the
README
to get some idea about it. - Use
rem
orem
instead ofpx
. - I notice that you are setting the
min-width
for the card on@media screen and (min-width:1440px)
. First, It doesn't need to be in1440px
, and second, the1440px
in thestyle-guide.md
has nothing to do with the@media
query. - Any elements that have
:hover
or:active
states should be interactive elements, which in this case link elements.
That's it! Hopefully, this is helpful!
Marked as helpful