Design comparison
Community feedback
- @ofthewildfirePosted 12 months ago
Hiya
Great solution, however, I think it would be an improvement to adjust the unit used in your max-width on your blog__card :) Currently you are used a fixed max-width, which means when you zoom in, the card gets squished and does not adapt! To resolve this using a unit value such as
rem
would be way better..blog__card { max-width: 20rem; }
I also think that changing the <h2> to an <h1> might server accessibility a bit better, it is the heading and that seems important.
Overall a really good job ππ
Marked as helpful1 - @MrugeshDixit98Posted 12 months ago
Hey
Really helpful insight. I've updated the code as per your suggestions replacing px to rem for setting card's max width. And thank you for pointing our the accessibility issue <h2> might cause.
Great Reviewπ
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord