Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Response blog preview card using flexbox

MrugeshDixit98β€’ 30

@MrugeshDixit98

Desktop design screenshot for the Blog preview card coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

Kirsten βœ¨β€’ 460

@ofthewildfire

Posted

Hiya

Great solution, however, I think it would be an improvement to adjust the unit used in your max-width on your blog__card :) Currently you are used a fixed max-width, which means when you zoom in, the card gets squished and does not adapt! To resolve this using a unit value such as rem would be way better.

.blog__card {
	max-width: 20rem;
}

I also think that changing the <h2> to an <h1> might server accessibility a bit better, it is the heading and that seems important.

Overall a really good job πŸ™πŸš€

Marked as helpful

1
MrugeshDixit98β€’ 30

@MrugeshDixit98

Posted

Hey

Really helpful insight. I've updated the code as per your suggestions replacing px to rem for setting card's max width. And thank you for pointing our the accessibility issue <h2> might cause.

Great ReviewπŸ™‡

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord