Design comparison
Solution retrospective
I Want Your Feedback
Community feedback
- @HassiaiPosted almost 2 years ago
Replace <div class="parent"> with the main tag and <p> in <div class="box_two"> with <h1> to fix the accessibility issue. click here for more on web-accessibility and semantic html
There is no need for <div class="bg_desktop"> and <div class="bg_mobile"> in the html and it styling in the css rather use the images as background-image for the body in the mobile design. Give the body a background-repeat is no-repeat, background-size of contain. in the desktop design give the body a background-position: bottom.
Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here
Hope am helpful.
Well done for completing this challenge. HAPPY CODING
Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here Hope am helpful.
Well done for completing this challenge. HAPPY CODING
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord